rjmccall added inline comments.

================
Comment at: lib/CodeGen/CGObjCMac.cpp:7274
+        // Classrefs pointing at Objective-C stub classes have the least
+        // significant bit set to 1.
+        auto *Tag = llvm::ConstantInt::get(CGM.IntPtrTy, 1);
----------------
slavapestov wrote:
> rjmccall wrote:
> > This isn't for an arbitrary class ref, it's for the global class list.  I'd 
> > say something like "the global class list sets the LSB to 1 on any class 
> > stubs".
> Can you explain what the difference is? My understanding is that the thing 
> you pass to objc_loadClassref() (or load from directly) is a "classref". This 
> is for classes you reference, not classes you define.
Oh, I see what you're saying, nevermind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59628/new/

https://reviews.llvm.org/D59628



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to