rjmccall added inline comments.
================ Comment at: lib/Sema/SemaDecl.cpp:11648-11651 + // In OpenCL we don't allow to initialize objects in local address space. + if (getLangOpts().OpenCL && + Var->getType().getAddressSpace() == LangAS::opencl_local) + return; ---------------- Anastasia wrote: > bader wrote: > > Shouldn't we invalidate Var declaration? > This early exit is to prevent adding default initializer implicitly to the > declarations that are valid. "In OpenCL, we can't initialize objects in the __local address space, even implicitly, so don't synthesize an implicit initializer." I think it's important to add the underscores on `__local` to make it obvious that we're talking about OpenCL's "local" address space, not the address space that local variables appear in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59646/new/ https://reviews.llvm.org/D59646 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
