bcain added a comment. In D58091#1397586 <https://reviews.llvm.org/D58091#1397586>, @jyknight wrote:
> I think this warning (-Wbuiltin-requires-header) doesn't really make sense as > its own warning. > > We already have two related (on-by-default) warnings. ... In D58091#1414250 <https://reviews.llvm.org/D58091#1414250>, @bcain wrote: > ... > FWIW, I'm satisfied with the fix as proposed here for now and I wouldn't be > opposed to following up with an improvement over other warnings in lieu of > this warning. > > @jyknight -- James, (or others) care to weigh in on this proposal? @jdoerfert and @jyknight -- let's please un-stall this review. James: is this change acceptable or unacceptable as-is? Could we follow up with a change that removed this warning? Johannes: if it's acceptable to James, let's please submit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https://reviews.llvm.org/D58091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
