asb added a comment. In D59233#1439656 <https://reviews.llvm.org/D59233#1439656>, @hubert.reinterpretcast wrote:
> Thanks @xingxue for the review. I will update for the error handling before > committing. Use of report_fatal_error/llvm_unreachable isn't fully consistent within the LLVM codebase, but I think your choices here are sensible. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59233/new/ https://reviews.llvm.org/D59233 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
