kadircet added a comment. In D59640#1438248 <https://reviews.llvm.org/D59640#1438248>, @ioeric wrote:
> should we update YAML? I suppose we are only keeping it alive for the sake of tests, but that seems like an enough reason updating that as well. ================ Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:526 S.ID = std::move(ID); + std::string TemplateArgumentList = printTemplateArgsAsWritten(ND); + S.TemplateArgumentList = TemplateArgumentList; ---------------- ioeric wrote: > put this near `ReturnType` initialization. tried to move it to closest place I can get, can't put after this if since template specialization params are not indexed for code completion, we'll simply end up dropping those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59640/new/ https://reviews.llvm.org/D59640 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits