ilya-biryukov added inline comments.

================
Comment at: clang/lib/AST/TypePrinter.cpp:1635
 
+static void printArgument(const TemplateArgument &A, const PrintingPolicy &PP,
+                          llvm::raw_ostream &OS) {
----------------
ilya-biryukov wrote:
> NIT: consider also adding a test in the clang code.
> Some developers don't build `tools-extra`.
It seems the amount of test infrastructure for running this in clang might be 
overwhelming.
It's just not worth it probably, having a test in clangd is good enough!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59354/new/

https://reviews.llvm.org/D59354



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to