nridge added a comment. In D59407#1430656 <https://reviews.llvm.org/D59407#1430656>, @kadircet wrote:
> I believe it makes sense to deduplicate SymbolIDs for RelationSlab. > Up until now, we mostly had only one occurence of a SymbolID in a Slab, but > RelationSlab does not follow that assumption. Just to make sure I understand, do you mean: (A) When adding a `SymbolID` to an entry's value, check that it's not already there; or (B) Try to conserve space by not storing `SymbolID`s directly in the entries, but storing an index into a separate list of unique `SymbolID`s. If it's (B), how many bytes should the index be? Are the space gains worth the complexity, given that `SymbolID` is only 8 bytes to begin with? (As compared to say, the filenames in `Ref`, which can be much longer, making this sort of optimization more clearly worth it.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
