mikhail.ramalho added a comment. In D54978#1431786 <https://reviews.llvm.org/D54978#1431786>, @ddcc wrote:
> In D54978#1431430 <https://reviews.llvm.org/D54978#1431430>, @mikhail.ramalho > wrote: > > > Sorry for the massive delay, but I just updated the `FindZ3` script to > > retrieve the version from the lib. I changed it to use `try_run` instead of > > `try_compile` so we can get the version number. > > > > I tried to use @brzycki code to get the version from the header, however, > > it's not working for Z3 4.8.4. In Z3 4.8.3 the FULL_VERSION is a nice `"Z3 > > 4.8.3.0"` but in version 4.8.4 it's `"Z3 4.8.4.10272 d6df51951f4c master > > z3-4.8.4"` and cmake fails with the following message: > > > Thanks for making the changes! Is this being parsed from e.g. > `/usr/include/z3_version.h`? I checked their code, and I have a local build > of z3 4.8.5.0, but I'm not seeing those changes to the version string: > > #define Z3_FULL_VERSION "Z3 4.8.5.0" > Nope, I downloaded it from release page on github: https://github.com/Z3Prover/z3/releases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
