lebedev.ri added a comment.

In D59336#1429564 <https://reviews.llvm.org/D59336#1429564>, @aaron.ballman 
wrote:

> This is missing test cases that demonstrate the behavior is what we expect it 
> to be for ObjC++ code vs C++ code.


Looks like phab has again consumed the email comments.
Might be a good idea to add the backlogged test coverage too.

https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190311/264471.html

>> test?
> 
> I was uncertain whether or not this change required new tests. A previous 
> change which disabled this check in languages other than C++ did not include 
> additional tests:
>  
> https://github.com/llvm/llvm-project/commit/ec3e5d6fd87862eb77a2b0320d79b9a4427d39df#diff-a491be84e1b831aeaea56c39b5eb898c
>  If there is a preference to add tests for this change, I can do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59336/new/

https://reviews.llvm.org/D59336



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to