baloghadamsoftware added inline comments.
================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:325
+ std::string FullOption =
+ (llvm::Twine() + FullName + ":" + OptionName).str();
+
----------------
Is this the most efficient way to concatenate `StringRef`s?
================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:443
+ StringRef SuppliedChecker(Config.first().substr(0, Pos));
+ StringRef SuppliedOption(Config.first().drop_front(Pos + 1));
----------------
What about `Config.first().split(":")`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57860/new/
https://reviews.llvm.org/D57860
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
