gribozavr marked 2 inline comments as done. gribozavr added inline comments.
================ Comment at: clang-tools-extra/clangd/index/Ref.cpp:1 +#include "Ref.h" + ---------------- ioeric wrote: > License? Added. ================ Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:14 #include "CodeCompletionStrings.h" +#include "ExpectedTypes.h" #include "Logger.h" ---------------- ioeric wrote: > Is this change relevant in this patch? Yes, once I replaced inclusion of Index.h with a more specific file somewhere else, SymbolCollector.cpp stopped building because it relied on transitive inclusion of ExpectedTypes.h. ================ Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:16 #include "index/Serialization.h" +#include "index/Symbol.h" #include "index/SymbolCollector.h" ---------------- ioeric wrote: > Maybe also include Ref.h? Added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58778/new/ https://reviews.llvm.org/D58778 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
