xur added inline comments.
================ Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:756 + // For COFF, the comdat group name must be the name of a symbol in the + // group. Use the counter variable name. + Cmdt = M->getOrInsertComdat( ---------------- So with the patch, COFF and ELF have the same way of naming. Can we simplify the code by hosting the common code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58737/new/ https://reviews.llvm.org/D58737 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits