lewmpk marked 2 inline comments as done and an inline comment as not done.
lewmpk added inline comments.
================
Comment at: clang-tidy/modernize/UseOverrideCheck.h:23
+ : ClangTidyCheck(Name, Context),
+ IgnoreDestructors(Options.get("IgnoreDestructors", false)) {}
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
----------------
JonasToth wrote:
> That requires additional methods for the function for the configuration to
> function properly. Please see other checks and implement that the same way.
Could you elaborate? I looked at other checks and they seem to implement it the
same way.
/llvm/tools/clang/tools/extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:74
```
CheckFunctionCalls(Options.get("CheckFunctionCalls", false)),
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58731/new/
https://reviews.llvm.org/D58731
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
