emilio marked 2 inline comments as done. emilio added a comment. Huh, somehow forgot to press "Submit" this morning :)
================ Comment at: clang/tools/c-index-test/c-index-test.c:1695 + CXType RT = clang_getResultType(T); + if (RT.kind != CXType_Invalid) + PrintSingleTypeSize(RT, " [resulttype=%s] [resulttypekind=%s]", ---------------- Anastasia wrote: > emilio wrote: > > Anastasia wrote: > > > Should it not return undeduced error in the other case? > > I'm not sure what you mean, can you clarify? > > > > The undeduced error is only returned when you try to access the `Auto` type > > which is the return value, not the function type, which has a known layout. > > > > So in the error case, `T` here is the `auto Tie(void*) const;` type, and > > `RT` is the undeduced `auto` type, which is what crashed. > > > > We had no way to exercise this in `c-index-test`, so I changed it to > > exercise this codepath too. I can add a `CHECK` for the error code if you > > want. > Yep, error check would be good since it's covers better changes in your patch. Alrighty, done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58569/new/ https://reviews.llvm.org/D58569 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
