jfb added a comment.

I think (with test updates) this will be good to go once D58188 
<https://reviews.llvm.org/D58188> lands.



================
Comment at: tools/clang/lib/CodeGen/CGDecl.cpp:1158
+  llvm::StructType *STy = dyn_cast<llvm::StructType>(Ty);
+  if (STy && (STy == Loc.getElementType()) &&
+      shouldSplitStructStore(CGM, ConstantSize)) {
----------------
Can you leave a FIXME here to handle `STY != Loc.getElementType()`, as well as 
another FIXME to handle non-struct aggregate types such as arrays? I'm happy to 
do them as a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57898/new/

https://reviews.llvm.org/D57898



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to