ABataev added inline comments.
================
Comment at: lib/AST/OpenMPClause.cpp:1469
void OMPClausePrinter::VisitOMPFromClause(OMPFromClause *Node) {
if (!Node->varlist_empty()) {
----------------
lildmh wrote:
> ABataev wrote:
> > Better to split this patch into 2: one for `to` clause and another one for
> > `from` clause
> Hi Alexey,
>
> Thanks for the quick review! The code for `to` and `from` clauses are almost
> identical, so I prefer to have them in the same patch. Besides I don't have
> commit privilege, so it causes more time to me to have multiple patches. But
> if you think it's crucial to split it. I can do it. What do you think?
Hi Lingda, it is clang/LLVM policy to make patches as small as possible (for
better "reviewability", reliability, trackability etc.). If it is possible to
split the patch into several parts, this must be done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58523/new/
https://reviews.llvm.org/D58523
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
