ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM, but see the comment about avoiding code duplication ================ Comment at: lib/Index/IndexDecl.cpp:678 IndexCtx.indexTypeSourceInfo(TTP->getDefaultArgumentInfo(), Parent); + if(IndexCtx.shouldIndexTemplateParameters()) + IndexCtx.handleDecl(TTP); ---------------- Maybe do it once on top of `TP` to avoid code duplication? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits