NoQ accepted this revision. NoQ added a comment. Herald added a subscriber: jdoerfert.
> since I couldn't reproduce the error Me neither, actually :/ This patch does provide a backup plan and it makes the code prettier, so we should definitely land it and i'm really greatful for it, but the option seems to work correctly in all possible ways even without it. Long-term, i guess, we could try to unlock ourselves the capability to rename checkers as much as we want by introducing checker aliases (which would work both for the purposes of enabling/disabling checkers and for checker options). ================ Comment at: unittests/StaticAnalyzer/AnalyzerOptionsTest.cpp:67 // Checker true has no option specified. It should get the default value when // search in parents turned off and false when search in parents turned on. ---------------- "`CheckerTwo`" was probably meant here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57579/new/ https://reviews.llvm.org/D57579 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
