aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: lib/Parse/ParseStmt.cpp:1090-1091
+ R = handleExprStmt(Res, SubStmtCtx);
+ if (R.isUsable())
+ R = Actions.ProcessStmtAttributes(R.get(), attrs, attrs.Range);
}
----------------
rsmith wrote:
> aaron.ballman wrote:
> > Should this be done as part of `handleExprStmt()`?
> In principle that might make sense, but it'd require passing the attributes
> through a few extra layers, and also making sure the attributes aren't
> handled twice along the more-common statement parsing codepaths. I'm inclined
> to defer that until we have a need to have the attributes in hand when
> processing a full-expression (and I suspect that time may never come).
Yeah, I think it's worth delaying that change then. Thank you for the
explanation!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57984/new/
https://reviews.llvm.org/D57984
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
