lildmh marked an inline comment as done.
lildmh added a comment.
Hi Alexey,
Again thanks for your review! The codegen completely ignores any mapper related
info for now, so it should not crash map clause codegen. It also passed the
regression test, so map clause codegen should be fine.
================
Comment at: include/clang/AST/OpenMPClause.h:4193
ArrayRef<SourceLocation> MapModifiersLoc,
+ NestedNameSpecifierLoc MapperQualifierLoc,
+ DeclarationNameInfo MapperIdInfo,
----------------
ABataev wrote:
> Also would be good to pack the parameters into the structure.
Among these parameters:
1. 2 of them are for modifiers. Since mapper can also be used in `to` and
`from` clauses, it is not good to combine mapper info with them.
2. 2 of them are mapper info. I can combine `MapperQualifierLoc` and
`MapperIdInfo` into a structure. It's not a big saving though (only reduce one
parameter). Do you want me to do that?
3. 4 of them are number of vars... It seems not a good idea to combine them
into one structure.
5. The rest are locations. They are kinda all over the place. It doesn't seem a
good idea to combine them as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58074/new/
https://reviews.llvm.org/D58074
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
