zinovy.nis marked an inline comment as done. zinovy.nis added inline comments.
================ Comment at: clang-tidy/tool/clang-tidy-diff.py:76 + t = threading.Thread(target=tidy_caller, args=(task_queue, lock, timeout)) + t.daemon = True + t.start() ---------------- JonasToth wrote: > why daemonize? Who kills that thread in the end? I think it's not the best > choice. The script can be interrupted with keyabord or other signal, so it need not wait for any worker thread. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
