[PATCH] D58161: Print a note to the called macro when diagnosing err_embedded_directive

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: clang/lib/Lex/PPMacroExpansion.cpp:497
+
     Args = ReadMacroCallArgumentList(Identifier, MI, ExpansionEnd);
 
----------------
Can this re-enter, something like:
  MACRO1(MACRO2(a1), MACRO3(
  #include "asdf"
  )
In this case, I think your diagnostic might do a null-deref. Maybe just add 
this test case and add a null test for it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58161/new/

https://reviews.llvm.org/D58161



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits