Author: nico Date: Mon Feb 11 12:33:22 2019 New Revision: 353744 URL: http://llvm.org/viewvc/llvm-project?rev=353744&view=rev Log: Fix a few tests that were missing ':' on CHECK lines and weren't testing anything.
Found by `git grep '\/\/ CHECK-[^: ]* ' clang/test/ | grep -v RUN:`. Also tweak CodeGenCXX/arm-swiftcall.cpp to still pass now that it checks more. Differential Revision: https://reviews.llvm.org/D58061 Modified: cfe/trunk/test/AST/ast-dump-attr.cpp cfe/trunk/test/CodeGenCXX/arm-swiftcall.cpp cfe/trunk/test/CodeGenCXX/cxx1z-init-statement.cpp cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp cfe/trunk/test/CodeGenCXX/debug-info-inheriting-constructor.cpp cfe/trunk/test/CodeGenCXX/vtable-layout.cpp cfe/trunk/test/CodeGenObjC/gnu-init.m cfe/trunk/test/CodeGenObjC/os_log.m Modified: cfe/trunk/test/AST/ast-dump-attr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/ast-dump-attr.cpp?rev=353744&r1=353743&r2=353744&view=diff ============================================================================== --- cfe/trunk/test/AST/ast-dump-attr.cpp (original) +++ cfe/trunk/test/AST/ast-dump-attr.cpp Mon Feb 11 12:33:22 2019 @@ -197,7 +197,7 @@ namespace TestSuppress { [[gsl::suppress("on-decl")]] void TestSuppressFunction(); // CHECK: FunctionDecl{{.*}} TestSuppressFunction - // CHECK-NEXT SuppressAttr{{.*}} on-decl + // CHECK-NEXT: SuppressAttr{{.*}} on-decl void f() { int *i; Modified: cfe/trunk/test/CodeGenCXX/arm-swiftcall.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/arm-swiftcall.cpp?rev=353744&r1=353743&r2=353744&view=diff ============================================================================== --- cfe/trunk/test/CodeGenCXX/arm-swiftcall.cpp (original) +++ cfe/trunk/test/CodeGenCXX/arm-swiftcall.cpp Mon Feb 11 12:33:22 2019 @@ -120,6 +120,6 @@ TEST(struct_indirect_1) class struct_trivial { int x; }; -// CHECK-LABEL define void @test_struct_trivial(i32{{( %.*)?}}) +// CHECK-LABEL: define swiftcc void @test_struct_trivial(i32{{( %.*)?}}) extern "C" SWIFTCALL void test_struct_trivial(struct_trivial triv) {} Modified: cfe/trunk/test/CodeGenCXX/cxx1z-init-statement.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cxx1z-init-statement.cpp?rev=353744&r1=353743&r2=353744&view=diff ============================================================================== --- cfe/trunk/test/CodeGenCXX/cxx1z-init-statement.cpp (original) +++ cfe/trunk/test/CodeGenCXX/cxx1z-init-statement.cpp Mon Feb 11 12:33:22 2019 @@ -5,7 +5,7 @@ void f() { // CHECK: %[[A:.*]] = alloca i32, align 4 // CHECK-NEXT: store i32 5, i32* %[[A]], align 4 // CHECK-NEXT: %[[B:.*]] = load i32, i32* %[[A]], align 4 - // CHECK-NEXT %[[C:.*]] = icmp slt i32 %[[B]], 8 + // CHECK-NEXT: %[[C:.*]] = icmp slt i32 %[[B]], 8 if (int a = 5; a < 8) ; } Modified: cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp?rev=353744&r1=353743&r2=353744&view=diff ============================================================================== --- cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp (original) +++ cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp Mon Feb 11 12:33:22 2019 @@ -80,7 +80,7 @@ auto mem_ptr_test(MemPtrT x, MemPtrT y) // CHECK: %cmp.ptr.null = icmp eq [[TY]] %lhs.memptr.ptr, 0 // CHECK: %cmp.adj = icmp eq [[TY]] %lhs.memptr.adj, %rhs.memptr.adj // CHECK: %[[OR:.*]] = or i1 - // CHECK-SAME %cmp.adj + // CHECK-SAME: %cmp.adj // CHECK: %memptr.eq = and i1 %cmp.ptr, %[[OR]] // CHECK: %sel.eq = select i1 %memptr.eq, i8 [[EQ]], i8 [[NE]] // CHECK: %__value_ = getelementptr inbounds %[[SE]], %[[SE]]* %[[DEST]] Modified: cfe/trunk/test/CodeGenCXX/debug-info-inheriting-constructor.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/debug-info-inheriting-constructor.cpp?rev=353744&r1=353743&r2=353744&view=diff ============================================================================== --- cfe/trunk/test/CodeGenCXX/debug-info-inheriting-constructor.cpp (original) +++ cfe/trunk/test/CodeGenCXX/debug-info-inheriting-constructor.cpp Mon Feb 11 12:33:22 2019 @@ -9,9 +9,9 @@ struct B : A { A::A(int i, ...) {} // CHECK: define void @{{.*}}foo -// CHECK-NOT ret void +// CHECK-NOT: ret void // CHECK: call void @llvm.dbg.declare -// CHECK-NOT ret void +// CHECK-NOT: ret void // CHECK: call void @llvm.dbg.declare(metadata %{{.*}}** %{{[^,]+}}, // CHECK-SAME: metadata ![[THIS:[0-9]+]], metadata !DIExpression()), !dbg ![[LOC:[0-9]+]] // CHECK: ret void, !dbg ![[NOINL:[0-9]+]] Modified: cfe/trunk/test/CodeGenCXX/vtable-layout.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/vtable-layout.cpp?rev=353744&r1=353743&r2=353744&view=diff ============================================================================== --- cfe/trunk/test/CodeGenCXX/vtable-layout.cpp (original) +++ cfe/trunk/test/CodeGenCXX/vtable-layout.cpp Mon Feb 11 12:33:22 2019 @@ -1412,7 +1412,7 @@ struct D : virtual C { // CHECK-35-NEXT: 13 | void Test28::B::b() // // CHECK-35: VTable indices for 'Test28::E' (1 entries). -// CHECK-35-NEXT : 0 | void Test28::E::e() +// CHECK-35-NEXT: 0 | void Test28::E::e() // CHECK-35: Construction vtable for ('Test28::D', 0) in 'Test28::E' (13 entries). // CHECK-35-NEXT: 0 | vbase_offset (8) Modified: cfe/trunk/test/CodeGenObjC/gnu-init.m URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/gnu-init.m?rev=353744&r1=353743&r2=353744&view=diff ============================================================================== --- cfe/trunk/test/CodeGenObjC/gnu-init.m (original) +++ cfe/trunk/test/CodeGenObjC/gnu-init.m Mon Feb 11 12:33:22 2019 @@ -14,7 +14,7 @@ // Check that we get a class ref to the defined class. // CHECK-NEW: @._OBJC_INIT_CLASS_X = global -// CHECK-NEW-SAME* @._OBJC_CLASS_X, section "__objc_classes" +// CHECK-NEW-SAME: @._OBJC_CLASS_X, section "__objc_classes" // Check that we emit the section start and end symbols as hidden globals. // CHECK-NEW: @__start___objc_selectors = external hidden global i8* Modified: cfe/trunk/test/CodeGenObjC/os_log.m URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/os_log.m?rev=353744&r1=353743&r2=353744&view=diff ============================================================================== --- cfe/trunk/test/CodeGenObjC/os_log.m (original) +++ cfe/trunk/test/CodeGenObjC/os_log.m Mon Feb 11 12:33:22 2019 @@ -50,7 +50,7 @@ void *test_builtin_os_log(void *buf) { // CHECK-O0: %[[V4:.*]] = ptrtoint %[[TY0]]* %[[V3]] to i64 // CHECK-O0: call void @__os_log_helper_1_2_1_8_64(i8* %[[V0]], i64 %[[V4]]) // CHECK-O0: %[[V5:.*]] = bitcast %[[TY0]]* %[[V3]] to i8* - // CHECK-O0-NOT call void (...) @llvm.objc.clang.arc.use({{.*}} + // CHECK-O0-NOT: call void (...) @llvm.objc.clang.arc.use({{.*}} // CHECK-O0: call void @llvm.objc.release(i8* %[[V5]]) // CHECK-O0: ret i8* %[[V0]] } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
