sbc100 added inline comments.
================ Comment at: lib/Driver/ToolChains/WebAssembly.cpp:50 + bool HasNoPthread = + !Pthread && DriverArgs.hasArg(clang::driver::options::OPT_no_pthread); + ---------------- tlively wrote: > Should this logic use `getLastArg` or perhaps `getLastArgNoClaim` to check > only that the final requested configuration is consistent rather than > checking all intermediate configurations? Can you remove all the "clang::driver" namspace qualification here since there is a "using" above? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
