JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
This makes sense to me, just one nit. ================ Comment at: lib/CodeGen/CGDebugInfo.cpp:2304 + assert((!M || (M->Name == CGM.getLangOpts().ModuleName)) && + "clang module without ASTFile was not specified by -fmodule-name"); + ---------------- Maybe it's just me but I had to reread this sentence a few times to be sure what you meant by the double negation. Maybe `clang module without ASTFile must be specified by -fmodule-name` is easier to grok. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57976/new/ https://reviews.llvm.org/D57976 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
