efriedma added inline comments.
================ Comment at: lib/Sema/JumpDiagnostics.cpp:347 + LabelAndGotoScopes[S] = ParentScope; + Jumps.push_back(S); + } ---------------- This doesn't look right; I think we need to add it to IndirectJumps instead. This probably impacts a testcase like the following: ``` struct S { ~S(); }; int f() { { S s; asm goto(""::::BAR); return 1; } BAR: return 0; } ``` (gcc currently accepts this and skips running the destructor, but I'm pretty sure that's a bug.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits