erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.

================
Comment at: clang/include/clang/AST/ASTContext.h:2092
+  Optional<CharUnits> getTypeSizeInCharsIfKnown(QualType Ty) const {
+    if (Ty->isIncompleteType() || Ty->isDependentType())
+      return None;
----------------
aaron.ballman wrote:
> Can you add a dependent type test as well?
I don't think its possible to get a dependent type here, since this feature is 
only supported in C mode.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57064/new/

https://reviews.llvm.org/D57064



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to