riccibruno added a comment. In D57098#1367816 <https://reviews.llvm.org/D57098#1367816>, @steveire wrote:
> Thanks for doing this! > > It would be easier to review (now and in the future!) if you split it into at > least 3 commits > > - Refactor use trailing objects without introducing the Association class > - The change to use bitfields and Stmt.h > - Introduce new class GenericSelectionExpr::Association > > Thanks, > > Stephen Is it okay if I split it into: 1. `llvm::TrailingObjects` + bit-fields of `Stmt` 2. Introduce `GenericSelectionExpr::Association` since using `llvm::TrailingObjects` and using the bit-fields of `Stmt` are closely related and come under the title "[AST] Pack GenericSelectionExpr". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57098/new/ https://reviews.llvm.org/D57098 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
