melver added a comment.

>> This generally looks sane. What will happen on windows though? Will it 
>> silently fa
> 
> AFAIK PassPlugin::Load uses sys::DynamicLibrary::getPermanentLibrary, which 
> uses DynamicLibrary::HandleSet::AddLibrary which works for Windows as well. 
> (The story is similar to legacy -fplugin=).

s/AddLibrary/DLOpen/ -- DLOpen and others in DynamicLibrary:: are wrappers 
around platform-specific code. On Windows the implementation is in: 
llvm/lib/Support/Windows/DynamicLibrary.inc


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56935/new/

https://reviews.llvm.org/D56935



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to