lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
LG other than two nits, thank you!
================
Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:25
AST_MATCHER(CXXRecordDecl, hasNonStaticMethod) {
+ return hasMethod(unless(anyOf(isStaticStorageClass(), isImplicit())))
----------------
Please do rename it though, from `hasNonStaticMethod` to
`hasNonStaticNonImplicitMethod` or something.
================
Comment at: test/clang-tidy/misc-non-private-member-variables-in-classes.cpp:38
+// Only data and implicit methods, do not warn
+
----------------
Can you please duplicate this test and add one static method (into
`S1Implicit`, i think?).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56966/new/
https://reviews.llvm.org/D56966
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
