pcc added inline comments.
================ Comment at: cfe/trunk/include/clang/Driver/Options.td:1657 + " | pattern">, Values<"uninitialized,pattern">; +def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, + Flags<[CC1Option]>, ---------------- jfb wrote: > pcc wrote: > > I noticed that this introduces a parsing ambiguity on the command line: the > > flag > > `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` > > can be interpreted either as this flag or as `-e > > nable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang`, > > meaning "tell the linker to use that long symbol name as the program's > > entry point". Worth fixing (e.g. by renaming to `--enable-...`)? It's > > probably a good idea to rename it every so often just to keep people on > > their toes anyway. > Don't we have the same issue with: > > ``` > > include/clang/Driver/CC1Options.td:def emit_html : Flag<["-"], "emit-html">, > include/clang/Driver/CC1Options.td:def emit_module : Flag<["-"], > "emit-module">, > include/clang/Driver/CC1Options.td:def emit_module_interface : Flag<["-"], > "emit-module-interface">, > include/clang/Driver/CC1Options.td:def emit_header_module : Flag<["-"], > "emit-header-module">, > include/clang/Driver/CC1Options.td:def emit_pch : Flag<["-"], "emit-pch">, > include/clang/Driver/CC1Options.td:def emit_llvm_bc : Flag<["-"], > "emit-llvm-bc">, > include/clang/Driver/CC1Options.td:def emit_llvm_only : Flag<["-"], > "emit-llvm-only">, > include/clang/Driver/CC1Options.td:def emit_codegen_only : Flag<["-"], > "emit-codegen-only">, > include/clang/Driver/CC1Options.td:def emit_obj : Flag<["-"], "emit-obj">, > include/clang/Driver/CC1Options.td:def emit_llvm_uselists : Flag<["-"], > "emit-llvm-uselists">, > include/clang/Driver/CC1Options.td:def enable_split_dwarf : Flag<["-"], > "enable-split-dwarf">, > include/clang/Driver/CC1Options.td:def enable_split_dwarf_EQ : Joined<["-"], > "enable-split-dwarf=">, > include/clang/Driver/CC1Options.td:def error_on_deserialized_pch_decl : > Separate<["-"], "error-on-deserialized-decl">, > include/clang/Driver/CC1Options.td:def error_on_deserialized_pch_decl_EQ : > Joined<["-"], "error-on-deserialized-decl=">, > include/clang/Driver/Options.td:def emit_ast : Flag<["-"], "emit-ast">, > include/clang/Driver/Options.td:def emit_llvm : Flag<["-"], "emit-llvm">, > Flags<[CC1Option]>, Group<Action_Group>, > include/clang/Driver/Options.td:def exported__symbols__list : Separate<["-"], > "exported_symbols_list">; > include/clang/Driver/Options.td:def e : JoinedOrSeparate<["-"], "e">, > Group<Link_Group>; > include/clang/Driver/Options.td:def enable_trivial_var_init_zero : > Joined<["-"], > "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, > ``` > > ? Just the ones in `Options.td`, I believe (since this is a driver-only flag). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54604/new/ https://reviews.llvm.org/D54604 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
