dcoughlin added a comment.
ayartsev:
> This also may theoretically help to find defects if a tested code relays on a
> value returned from strcmp like
> if (strcmp(x, y) == 1) { ... }
I think it would be useful and not that difficult to write a checker that
checks for this explicitly. I don't think an AST-based/clang-tidycheck would
quite be enough because I suspect programmers often store the result of
strcmp() in a local before using it. One approach would be to have a
path-sensitive checker keep a set of symbolic result values from strcmp() and
diagnose if any is ever explicitly checked for (dis)-equality with -1 or 1.
http://reviews.llvm.org/D16317
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
