aaron.ballman added inline comments.
================
Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.h:26
@@ +25,3 @@
+/// - `HeaderFileExtensions`: a comma-separated list of filename extensions
of
+/// header files (no need to includ "."). "h" by default.
+/// For extension-less header files, using an empty string or leaving an
----------------
s/includ/include
Is "." tolerated in the extension? It sounds like you can write: `h,.hpp,hxx`
and it will work? Best to clarify the requirements (here and elsewhere). I
don't have a strong opinion on whether the extension should include the full
stop or not.
================
Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.h:28
@@ -22,1 +27,3 @@
+/// For extension-less header files, using an empty string or leaving an
+/// empty string between "," if there are other file extensions.
class GlobalNamesInHeadersCheck : public ClangTidyCheck {
----------------
What if you only want to match extensionless header files?
================
Comment at: clang-tidy/google/UnnamedNamespaceInHeaderCheck.h:25
@@ +24,3 @@
+/// - `HeaderFileExtensions`: a comma-separated list of filename extensions
of
+/// header files (no need to includ "."). "h,hh,hpp,hxx" by default.
+/// For extension-less header files, using an empty string or leaving an
----------------
s/includ/include
Same comment about use of ".".
================
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.h:27
@@ +26,3 @@
+/// - `HeaderFileExtensions`: a comma-separated list of filename extensions
of
+/// header files (no need to includ "."). ",h,hh,hpp,hxx" by default.
+/// For extension-less header files, using an empty string or leaving an
----------------
s/includ/include
Also, same comments about the full stop.
http://reviews.llvm.org/D16113
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
