aaron.ballman added a comment. In terms of implementation, the attribute code looks pretty close (just a few nits). However, someone more familiar with Obj-C should chime in with whether the attribute semantics make sense and whether the documentation will be sufficiently clear for an Objective-C user.
================ Comment at: clang/include/clang/Basic/AttrDocs.td:3506 +add the class to the list of non-lazily initialized classes. These are classes +that are realized at objc_init() time rather than when first referenced. + }]; ---------------- Add backticks around `objc_init()` because it should be in code font. ================ Comment at: clang/test/CodeGenObjC/non-lazy-classes.m:6-7 -@interface A @end +@interface A +@end @implementation A ---------------- Spurious change that can be reverted? ================ Comment at: clang/test/CodeGenObjC/non-lazy-classes.m:31-32 -@interface C : A @end +@interface C : A +@end @implementation C ---------------- Spurious change that can be reverted? ================ Comment at: clang/test/SemaObjC/attr-objc-non-lazy.m:35 +@end \ No newline at end of file ---------------- Please add a newline to the end of this file. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm.org/D56555 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
