mclow.lists marked 2 inline comments as done.
mclow.lists added inline comments.
================
Comment at: include/chrono:2667
+#if _LIBCPP_STD_VER > 17
+ constexpr chrono::day operator ""d(unsigned long long __d) noexcept
+ {
----------------
EricWF wrote:
> Including this file with Clang 6.0 in C++2a mode causes a compile error
> because of "-Wreserved-user-defined-literal". We need to wrap this block with:
>
> ```
> #if defined(__clang__)
> #pragma clang diagnostic push
> #pragma clang diagnostic ignored "-Wreserved-user-defined-literal"
> #endif
> [...]
> #if defined(__clang__)
> #pragma clang diagnostic pop
> #endif
> ```
I did this by defining `_LIBCPP_HAS_NO_CXX20_CHRONO_LITERALS` instead
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D51762/new/
https://reviews.llvm.org/D51762
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
