EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed.
Our constructors still have the same bug,. Are you planning on fixing those as well? Doing so will require a metric butt-tonne of overloads. If you're not planning on fixing the constructors, then can you explain why it's better that we're inconsistent? Otherwises, this patch looks mostly OK. However, it makes a bunch of previously lazy SFINAE eager. Here are some tests: https://gist.github.com/EricWF/88ceadf2bcdeef9f9d268b3a743dcd04 Is there a reason we can't use `__tuple_assignable` anymore? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50106/new/ https://reviews.llvm.org/D50106 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
