benhamilton added inline comments.
================
Comment at: lib/Format/TokenAnnotator.cpp:501
+ CurrentToken->Next->is(tok::equal))) ||
+ (CurrentToken->Previous->Previous == Left)) &&
Left->is(TT_ObjCMethodExpr)) {
----------------
I think you need to check if `CurrentToken->Previous` is null before
dereferencing it.
================
Comment at: lib/Format/TokenAnnotator.cpp:504
+ // An ObjC method call is rarely followed by an open parenthesis or
+ // an assignment. It also usually contains more than one token.
// FIXME: Do we incorrectly label ":" with this?
----------------
I think it's actually required to have more than one token. Can we reduce the
change to that?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56226/new/
https://reviews.llvm.org/D56226
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits