ilya-biryukov added a comment.

In D55994#1344717 <https://reviews.llvm.org/D55994#1344717>, @jkorous wrote:

> @ilya-biryukov Yes, that's true. I would still expect some performance gain 
> in more restrictive filtering on client's side - not sure how big though. 
> Anyway, seems like LSP folks think character + trigger context is good 
> enough. For example here:
>  https://github.com/Microsoft/language-server-protocol/issues/138


That would definitely mean less completion requests from the client, I doubt it 
would be the bottleneck for performance, though.
Thanks for the pointers, an insightful conversation on almost the same issue 
there.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55994/new/

https://reviews.llvm.org/D55994



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to