Nicola added a comment.

Since this review is just for a prototype, I'll leave some feedback after 
having played with it for a bit.
It seems to be quite trivial to add new builtins and fix existing ones 
(conversion builtins sat/rounding modes). One builtin that might have a small 
issue is the as_type builtin in which source and destination type need to have 
the same bitwidth. To get that to work I ended up patching TableGen to add !mul 
support for it (and set VectorSize to 1 for scalars).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53023/new/

https://reviews.llvm.org/D53023



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to