NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
It works! :D I guess, please commit this if you don't find anything better. ================ Comment at: test/Analysis/invalid-analyzer-config-value.c:72 +// even if -analyze isn't specified. +// RUN: %clang --analyze -Xclang -analyzer-config -Xclang remember=TheVasa %s + ---------------- Szelethus wrote: > Szelethus wrote: > > NoQ wrote: > > > This run-line *does* have `-analyze` specified, because that's what > > > `--analyze` expands to. I guess the test that we need would be along the > > > lines of `clang -Xclang -analyzer-config ...` without `--analyze`. > > Uhhhh sorry about that. > I checked this against a completely different file, and it works. Given that we stepped on this, i guess it's still worth it to rename the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
