klimek added a reviewer: bkramer. klimek added a comment. Adding Benjamin for an additional pair of eyes. Generally looks good.
================ Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:351 @@ +350,3 @@ + + // First, match the name. + if (!MatchNodeName(Pattern, Node)) ---------------- Perhaps comment that Pattern will be changed to the prefix, so it's clear afterwards. (I wonder whether returning a tuple might be slightly easier to understand here) http://reviews.llvm.org/D15506 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
