dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land.
This seems reasonable to me, although I have a question inline about why you are using `makeZeroElementRegion()`. ================ Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:224 + bool IsArray = false; + V = makeZeroElementRegion(State, V, ReturnTy, IsArray); + assert(!IsArray && "Returning array from a function!"); ---------------- I don't understand why you are using makeZeroElementRegion() here. Doesn't the assertion of !IsArray mean it must just return 'V'? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55804/new/ https://reviews.llvm.org/D55804 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
