rnk added inline comments.
================
Comment at: test/CodeGenCXX/mangle-address-space.cpp:7
+// CHECKNOOCL-LABEL: define {{.*}}void @_Z2f0Pc
+// WINNOOCL-LABEL: define {{.*}}void @"?f0@@YAXPEAD@Z"
+// CHECKOCL-LABEL: define {{.*}}void @_Z2f0PU9CLgenericc
----------------
You know, now that we have a demangler, I wonder if we shouldn't add a RUN line
like this to test that these names really do demangle properly:
`// RUN: %clang_cc1 %s ... -emit-bitcode -o - | llvm-nm -demangle - | FileCheck
%s --check-prefix=DEMANGLED`
================
Comment at: test/CodeGenOpenCL/address-spaces-mangling.cl:7
+// RUN: %clang_cc1 %s -ffake-address-space-map
-faddress-space-map-mangling=yes -triple x86_64-windows-pc -emit-llvm -o - |
FileCheck -check-prefixes=MS_ASMANG,MS_ASMAN10 %s
+// RUN: %clang_cc1 %s -cl-std=CL2.0 -ffake-address-space-map
-faddress-space-map-mangling=yes -triple x86_64-windows-pc -emit-llvm -o - |
FileCheck -check-prefixes=MS_ASMANG,MS_ASMAN20 %s
+// RUN: %clang_cc1 %s -ffake-address-space-map -faddress-space-map-mangling=no
-triple x86_64-windows-pc -emit-llvm -o - | FileCheck
-check-prefixes=MS_NOASMANG,MS_NOASMAN10 %s
----------------
I would replace `-triple x86_64-windows-pc` here and everywhere with `-triple
x86_64-windows-itanium` (or gnu instead of itanium) to test the Itanium
mangling on Windows. I don't think `x86_64-windows-pc` parses into a real
triple. After all, "pc" is parsed as the vendor, which is supposed to be second.
================
Comment at: test/CodeGenOpenCL/address-spaces-mangling.cl:24
// NOASMANG20: @_Z2ffPU9CLgenerici
+// MS_ASMANG10: @_Z2ffPi
+// MS_ASMANG20: @_Z2ffPU3AS4i
----------------
Why "MS_"? This isn't the MSVC environment, this is using the Itanium C++ ABI
mangling. Maybe WIN_ instead would be better?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55715/new/
https://reviews.llvm.org/D55715
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
