aaron.ballman added inline comments.

================
Comment at: include/clang/AST/Stmt.h:847
+                   const ASTContext *Context = nullptr,
+                   bool PrintCanonicalTypes = false) const;
 
----------------
I'm pretty wary of long lists of parameters that include booleans with default 
values. Why is `PrintCanonicalTypes` not part of the printing policy? I think 
that's where we should keep all the knobs relating to how the printing happens.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55552/new/

https://reviews.llvm.org/D55552



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to