xazax.hun added a comment. Sorry for the delay. The changes are looking good to me, although I think it might be worth to split this up into two patch, one NFC with the renaming, and one that actually introduces the changes.
@martong could you also take a look? First, we would also like to test this internally. just to make sure it works as intended. Could you rebase the path to current top of tree? Thanks! ================ Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:350 + bool VisitVarDecl(VarDecl *VD) { + if (!Opts->naiveCTUEnabled()) + return true; ---------------- Maybe we should also opt out for non-const VarDecls to avoid even attempting to import the initializer if we will not find it anyways. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46421/new/ https://reviews.llvm.org/D46421 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits