ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Many thanks for the fix, really important to get those cases right.
================
Comment at: unittests/clangd/XRefsTests.cpp:1228
+TEST(FindReferences, ExplicitSymbols) {
+ const char *Tests[] = {
----------------
hokein wrote:
> ilya-biryukov wrote:
> > I'm missing what does this test actually tests.
> > The absence of implicit references (I guess constructor expressions)?
> This test tests the cases where symbol is being marked implicit incorrectly,
> which will result in no result in xref.
Thanks for clarification! The tested cases were so simple that I though they
worked before.
(Which shows this change is very important, IMHO)
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55191/new/
https://reviews.llvm.org/D55191
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
