aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some minor nits ================ Comment at: lib/AST/ASTDumper.cpp:106 + const Decl *From = nullptr, + const char *label = nullptr); void dumpTemplateArgumentList(const TemplateArgumentList &TAL); ---------------- s/label/Label per naming conventions (same below). ================ Comment at: lib/AST/ASTDumper.cpp:733 + if (From) { + dumpDeclRef(From, label); ---------------- Elide braces. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55393/new/ https://reviews.llvm.org/D55393 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits