[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

This seems to be correct, but the test coverage could be improved.
There are no tests with `()` e.g.



================
Comment at: lib/Lex/PPExpressions.cpp:154-156
     // Consume the ).
-    Result.setEnd(PeekTok.getLocation());
     PP.LexNonComment(PeekTok);
+    Result.setEnd(PeekTok.getLocation());
----------------
I'm not sure this is covered with the test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54450/new/

https://reviews.llvm.org/D54450



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits