aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a few other small nits. ================ Comment at: lib/Sema/SemaDeclCXX.cpp:1904 + case Stmt::CXXTryStmtClass: + if (!Cxx2aLoc.isValid()) + Cxx2aLoc = S->getBeginLoc(); ---------------- `Cxx2aLoc.isInvalid()` ================ Comment at: lib/Sema/SemaDeclCXX.cpp:1956 + // + // In C++2a lifts this restriction, as long as inner statements do also + // apply to general constexpr rules. ---------------- This restriction is lifted in C++2a, as long as inner statements also apply the general constexpr rules. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55097/new/ https://reviews.llvm.org/D55097 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
