alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
In D54401#1320772 <https://reviews.llvm.org/D54401#1320772>, @Szelethus wrote: > In D54401#1318282 <https://reviews.llvm.org/D54401#1318282>, @alexfh wrote: > > > In D54401#1315354 <https://reviews.llvm.org/D54401#1315354>, @NoQ wrote: > > > > > The code looks good, but i vaguely remember that we might accidentally > > > break clang-tidy integration that uses this API to enable/disable > > > specific checkers via `-checks=-analyzer-...`. > > > > > > *summons @alexfh* > > > > > > It's hard to tell without trying. Could you build and test > > clang-tools-extra with this patch? There should be a test for the relevant > > functionality in clang-tidy. > > > It compiles without problem, and `check-all` doesn't produce a single > `clang-tools-extra` failure. Yay! Then I have no concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54401/new/ https://reviews.llvm.org/D54401 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
